From f7c298e2972e6a1eb8f9329272ed8e8c9549266c Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Mon, 26 Apr 2021 13:28:38 -0400 Subject: Remove denort optimization (#10350) denort is an optimization to "deno compile" to produce slightly smaller output. It's a decent idea, but causes a lot of negative side-effects: - Deno's link time is a source of constant agony both locally and in CI, denort doubles link time. - The release process is a long and arduous undertaking with many manual steps. denort necessitates an additional manual zip + upload from M1 apple computers. - The "deno compile" interface is complicated with the "--lite" option. This is confusing for uses ("why wouldn't you want lite?"). The benefits of this feature do not outweigh the negatives. We must find a different approach to optimizing "deno compile" output. --- .github/workflows/ci.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to '.github/workflows') diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b1adaab25..96fffee8c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -224,7 +224,6 @@ jobs: run: | cd target/release zip -r deno-x86_64-unknown-linux-gnu.zip deno - zip -r denort-x86_64-unknown-linux-gnu.zip denort ./deno types > lib.deno.d.ts - name: Pre-release (mac) @@ -235,7 +234,6 @@ jobs: run: | cd target/release zip -r deno-x86_64-apple-darwin.zip deno - zip -r denort-x86_64-apple-darwin.zip denort - name: Pre-release (windows) if: | @@ -244,7 +242,6 @@ jobs: matrix.profile == 'release' run: | Compress-Archive -CompressionLevel Optimal -Force -Path target/release/deno.exe -DestinationPath target/release/deno-x86_64-pc-windows-msvc.zip - Compress-Archive -CompressionLevel Optimal -Force -Path target/release/denort.exe -DestinationPath target/release/denort-x86_64-pc-windows-msvc.zip - name: Upload canary to dl.deno.land (unix) if: | @@ -376,7 +373,7 @@ jobs: - name: Clean before cache shell: bash run: | - rm -f target/*/deno target/*/denort target/*/test_server + rm -f target/*/deno target/*/test_server rm -rf target/*/examples/ rm -rf target/*/gn_out/ rm -rf target/*/*.zip -- cgit v1.2.3