From 3e51610bbb5d5d63863b9989690ca1e8127fdf88 Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Sun, 18 Oct 2020 12:12:17 -0400 Subject: Remove github actions cache (#8020) Running into issues with cache when trying to upgrade V8. Based on the analysis in https://github.com/denoland/deno/pull/7903#issuecomment-706252380 we know the cache is not providing much benefit. --- .github/workflows/ci.yml | 54 ------------------------------------------------ 1 file changed, 54 deletions(-) (limited to '.github/workflows') diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 55f8a7c37..a9c528e0c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -94,60 +94,6 @@ jobs: rustc --version cargo --version - - name: Configure cargo data directory - # After this point, all cargo registry and crate data is stored in - # $GITHUB_WORKSPACE/.cargo_home. This allows us to cache only the files - # that are needed during the build process. Additionally, this works - # around a bug in the 'cache' action that causes directories outside of - # the workspace dir to be saved/restored incorrectly. - run: echo "::set-env name=CARGO_HOME::$(pwd)/.cargo_home" - - - name: Cache - uses: actions/cache@v2 - with: - # Note: crates from the denoland/deno git repo always get rebuilt, - # and their outputs ('deno', 'libdeno.rlib' etc.) are quite big, - # so we cache only those subdirectories of target/{debug|release} that - # contain the build output for crates that come from the registry. - path: |- - .cargo_home - target/*/.* - target/*/build - target/*/deps - target/*/gn_out - key: deno-${{ matrix.os }}-${{ matrix.kind }}-${{ hashFiles('Cargo.lock') }} - restore-keys: | - deno-${{ matrix.os }}-${{ matrix.kind }}- - - # It seems that the 'target' directory does not always get restored - # from cache correctly on MacOS. In the build log we see the following: - # - # Fresh serde_derive v1.0.115 - # - # But a little while after that Cargo aborts because 'serde_derive' is - # now nowhere to be found. We're not the only ones experiencing this, - # see https://github.com/actions-rs/cargo/issues/111. - # - # error[E0463]: can't find crate for `serde_derive` - # ##[error] --> /Users/runner/.cargo/registry/src/github.com- - # | 1ecc6299db9ec823/serde-1.0.115/src/lib.rs:285:1 - # | - # 285 | extern crate serde_derive; - # | ^^^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate - - name: Work around MacOS + Cargo + Github Actions cache bug - if: runner.os == 'macOS' - run: | - cargo clean --locked --release \ - -p ast_node \ - -p is-macro \ - -p serde_derive \ - -p swc_ecma_codegen \ - -p swc_ecma_codegen_macros \ - -p swc_ecma_parser \ - -p swc_ecma_parser_macros \ - -p swc_visit \ - -p swc_visit_macros - - name: lint.py if: matrix.kind == 'lint' run: python ./tools/lint.py -- cgit v1.2.3