| Age | Commit message (Collapse) | Author |
|---|
|
necessary (#23258)
The TS language service requests source files via
[getSourceFile](https://github.com/nathanwhit/deno/blob/7a25fd5ef0a82c2aac76594ccd467e9210e92b80/cli/tsc/99_main_compiler.js#L560).
In that function, we [unconditionally
add](https://github.com/nathanwhit/deno/blob/7a25fd5ef0a82c2aac76594ccd467e9210e92b80/cli/tsc/99_main_compiler.js#L613-L614)
the source file to our sourceFileCache. The issue is that we only remove
things from that cache if the source file [becomes out of
date](https://github.com/nathanwhit/deno/blob/7a25fd5ef0a82c2aac76594ccd467e9210e92b80/cli/tsc/99_main_compiler.js#L777-L783).
For files that don't get changed, we keep them in the cache
indefinitely. So sometimes we keep SourceFile objects from being GC'ed
because they're retained in our cache, even though TS doesn't refer to
them any more. I see this in pretty much all of the heap snapshots I've
taken.
---
The fix here is pretty direct - just store weak references to the
sourcefiles in the cache. It doesn't really change our caching behavior,
it just prevents us from being the only retainer of a `SourceFile`. I
also split the `sourceFileCache` into a separate cache just for assets,
as we rely on those being alive.
The simpler fix is to only cache assets, but presumably that has a perf
impact.
---
In local testing, this PR reduced the size of the JS heap by about 1 GB
when using `deno lsp` in the Typescript repo.
|
|
|
|
Closes #23079
|
|
|
|
Closes https://github.com/denoland/deno/issues/21828.
This API is a huge footgun. And given that "Deno.serveHttp" is a
deprecated API that is discouraged to use (use "Deno.serve()"
instead); it makes no sense to keep this API around.
This is a step towards fully migrating to Hyper 1.
|
|
|
|
|
|
|
|
|
|
|
|
Remove some dead code in "99_main_compiler.js". Eagerly start the LSP
TSC host, it was adding some not needed complexity around the TSC thread code.
|
|
https://github.com/denoland/TypeScript/pull/9
|
|
This commit changes the argument that "op_load" accepts, from
a serde struct to "&str". This should equal to a slightly better
performance.
|
|
|
|
|
|
This commit removes "ThrottledCancellationToken" in favor of
"CancellationToken".
Since calling into Rust to check if Tokio's cancellation token has
already been canceled is really cheap, there's no need for us to
throttle this check and let TSC burn up CPU with heavy computation.
|
|
Co-authored-by: Marvin Hagemeister <marvin@deno.com>
|
|
This commit implements Symbol.dispose and Symbol.asyncDispose for
the relevant resources.
Closes #20839
---------
Signed-off-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
|
|
|
|
|
|
Closes https://github.com/denoland/vscode_deno/issues/410.
|
|
Fixes https://github.com/denoland/vscode_deno/issues/856.
|
|
Some people might not know what "entrypoint" means or where to put the
triple-slash directive.
|
|
Also improved the diagnostic when using something like `Deno.openKv` and
it doesn't exist.
|
|
|
|
invalidated between runs (#18541)
Regression caused by the performance improvement in #18329. Figuring
this out was hard. It's luckily still fast after this change.
Closes #18516
|
|
|
|
|
|
Closes #18171
|
|
This upgrades TypeScript to 5.0.2, but does not have ES decorator
support because swc does not support that yet.
|
|
errors (#18124)
Closes #18117
Closes #18121 (this is just over 10ms faster in a directory one up from
the root folder)
cc @nayeemrmn
|
|
This code is no longer used because we use swc for this now.
|
|
Co-authored-by: David Sherret <dsherret@gmail.com>
|
|
multiple places (#17410)
|
|
Yearly tradition of creating extra noise in git.
|
|
not debug (#16689)
|
|
|
|
|
|
Closes: #11853
|
|
Welcome to better optimised op calls! Currently opSync is called with parameters of every type and count. This most definitely makes the call megamorphic. Additionally, it seems that spread params leads to V8 not being able to optimise the calls quite as well (apparently Fast Calls cannot be used with spread params).
Monomorphising op calls should lead to some improved performance. Now that unwrapping of sync ops results is done on Rust side, this is pretty simple:
```
opSync("op_foo", param1, param2);
// -> turns to
ops.op_foo(param1, param2);
```
This means sync op calls are now just directly calling the native binding function. When V8 Fast API Calls are enabled, this will enable those to be called on the optimised path.
Monomorphising async ops likely requires using callbacks and is left as an exercise to the reader.
|
|
|
|
|
|
Fixes: #15111
|
|
|
|
Fixes a regression where this type checking error was being surfaced in certain scenarios.
|
|
|
|
|
|
|
|
This commit fixes source maps for files that contain emojis.
This is done by updating "deno_ast" to "0.14.1" for the case
of "--no-check" flag (ie using SWC emit) and by overriding
TSC's default base64 encoder (which turned out to be buggy)
for the type checking case.
|
|
|
