diff options
Diffstat (limited to 'runtime')
| -rw-r--r-- | runtime/js/40_process.js | 5 | ||||
| -rw-r--r-- | runtime/js/99_main.js | 99 | ||||
| -rw-r--r-- | runtime/worker_bootstrap.rs | 5 |
3 files changed, 108 insertions, 1 deletions
diff --git a/runtime/js/40_process.js b/runtime/js/40_process.js index c90f38664..e6a62dcf7 100644 --- a/runtime/js/40_process.js +++ b/runtime/js/40_process.js @@ -140,6 +140,11 @@ function run({ ...new SafeArrayIterator(ArrayPrototypeSlice(cmd, 1)), ]; } + internals.warnOnDeprecatedApi( + "Deno.run()", + (new Error()).stack, + `Use "Deno.Command()" API instead.`, + ); const res = opRun({ cmd: ArrayPrototypeMap(cmd, String), cwd, diff --git a/runtime/js/99_main.js b/runtime/js/99_main.js index 6c5ca3b59..54a4406b2 100644 --- a/runtime/js/99_main.js +++ b/runtime/js/99_main.js @@ -9,6 +9,8 @@ const { ArrayPrototypeFilter, ArrayPrototypeIncludes, ArrayPrototypeMap, + ArrayPrototypePop, + ArrayPrototypeShift, DateNow, Error, ErrorPrototype, @@ -23,6 +25,10 @@ const { ObjectValues, PromisePrototypeThen, PromiseResolve, + SafeSet, + StringPrototypeIncludes, + StringPrototypeSplit, + StringPrototypeTrim, Symbol, SymbolIterator, TypeError, @@ -89,6 +95,93 @@ ObjectDefineProperties(Symbol, { let windowIsClosing = false; let globalThis_; +let deprecatedApiWarningDisabled = false; +const ALREADY_WARNED_DEPRECATED = new SafeSet(); + +function warnOnDeprecatedApi(apiName, stack, suggestion) { + if (deprecatedApiWarningDisabled) { + return; + } + + if (ALREADY_WARNED_DEPRECATED.has(apiName + stack)) { + return; + } + + // If we haven't warned yet, let's do some processing of the stack trace + // to make it more useful. + const stackLines = StringPrototypeSplit(stack, "\n"); + ArrayPrototypeShift(stackLines); + while (true) { + // Filter out internal frames at the top of the stack - they are not useful + // to the user. + if ( + StringPrototypeIncludes(stackLines[0], "(ext:") || + StringPrototypeIncludes(stackLines[0], "(node:") + ) { + ArrayPrototypeShift(stackLines); + } else { + break; + } + } + // Now remove the last frame if it's coming from "ext:core" - this is most likely + // event loop tick or promise handler calling a user function - again not + // useful to the user. + if ( + StringPrototypeIncludes(stackLines[stackLines.length - 1], "(ext:core/") + ) { + ArrayPrototypePop(stackLines); + } + + let isFromRemoteDependency = false; + const firstStackLine = stackLines[0]; + if (firstStackLine && !StringPrototypeIncludes(firstStackLine, "file:")) { + isFromRemoteDependency = true; + } + + ALREADY_WARNED_DEPRECATED.add(apiName + stack); + console.error( + "%cWarning", + "color: yellow; font-weight: bold;", + ); + console.error( + `%c\u251c Use of deprecated "${apiName}" API.`, + "color: yellow;", + ); + console.error("%c\u2502", "color: yellow;"); + console.error( + "%c\u251c This API will be removed in Deno 2.0. Make sure to upgrade to a stable API before then.", + "color: yellow;", + ); + console.error("%c\u2502", "color: yellow;"); + console.error( + `%c\u251c Suggestion: ${suggestion}`, + "color: yellow;", + ); + if (isFromRemoteDependency) { + console.error("%c\u2502", "color: yellow;"); + console.error( + `%c\u251c Suggestion: It appears this API is used by a remote dependency.`, + "color: yellow;", + ); + console.error( + "%c\u2502 Try upgrading to the latest version of that dependency.", + "color: yellow;", + ); + } + + console.error("%c\u2502", "color: yellow;"); + console.error("%c\u2514 Stack trace:", "color: yellow;"); + for (let i = 0; i < stackLines.length; i++) { + console.error( + `%c ${i == stackLines.length - 1 ? "\u2514" : "\u251c"}\u2500 ${ + StringPrototypeTrim(stackLines[i]) + }`, + "color: yellow;", + ); + } + console.error(); +} + function windowClose() { if (!windowIsClosing) { windowIsClosing = true; @@ -432,7 +525,7 @@ function exposeUnstableFeaturesForWindowOrWorkerGlobalScope(options) { // FIXME(bartlomieju): temporarily add whole `Deno.core` to // `Deno[Deno.internal]` namespace. It should be removed and only necessary // methods should be left there. -ObjectAssign(internals, { core }); +ObjectAssign(internals, { core, warnOnDeprecatedApi }); const internalSymbol = Symbol("Deno.internal"); const finalDenoNs = { internal: internalSymbol, @@ -467,8 +560,10 @@ function bootstrapMainRuntime(runtimeOptions) { 3: inspectFlag, 5: hasNodeModulesDir, 6: maybeBinaryNpmCommandName, + 7: shouldDisableDeprecatedApiWarning, } = runtimeOptions; + deprecatedApiWarningDisabled = shouldDisableDeprecatedApiWarning; performance.setTimeOrigin(DateNow()); globalThis_ = globalThis; @@ -593,8 +688,10 @@ function bootstrapWorkerRuntime( 4: enableTestingFeaturesFlag, 5: hasNodeModulesDir, 6: maybeBinaryNpmCommandName, + 7: shouldDisableDeprecatedApiWarning, } = runtimeOptions; + deprecatedApiWarningDisabled = shouldDisableDeprecatedApiWarning; performance.setTimeOrigin(DateNow()); globalThis_ = globalThis; diff --git a/runtime/worker_bootstrap.rs b/runtime/worker_bootstrap.rs index aac665b05..e3bfc13b9 100644 --- a/runtime/worker_bootstrap.rs +++ b/runtime/worker_bootstrap.rs @@ -60,6 +60,7 @@ pub struct BootstrapOptions { pub has_node_modules_dir: bool, pub maybe_binary_npm_command_name: Option<String>, pub node_ipc_fd: Option<i64>, + pub disable_deprecated_api_warning: bool, } impl Default for BootstrapOptions { @@ -88,6 +89,7 @@ impl Default for BootstrapOptions { has_node_modules_dir: Default::default(), maybe_binary_npm_command_name: None, node_ipc_fd: None, + disable_deprecated_api_warning: false, } } } @@ -117,6 +119,8 @@ struct BootstrapV8<'a>( bool, // maybe_binary_npm_command_name Option<&'a str>, + // disable_deprecated_api_warning, + bool, ); impl BootstrapOptions { @@ -136,6 +140,7 @@ impl BootstrapOptions { self.enable_testing_features, self.has_node_modules_dir, self.maybe_binary_npm_command_name.as_deref(), + self.disable_deprecated_api_warning, ); bootstrap.serialize(ser).unwrap() |