diff options
Diffstat (limited to 'runtime/ops')
-rw-r--r-- | runtime/ops/fs.rs | 60 | ||||
-rw-r--r-- | runtime/ops/io.rs | 2 | ||||
-rw-r--r-- | runtime/ops/os/mod.rs | 6 | ||||
-rw-r--r-- | runtime/ops/signal.rs | 8 |
4 files changed, 38 insertions, 38 deletions
diff --git a/runtime/ops/fs.rs b/runtime/ops/fs.rs index ebd24ebe0..8d719393f 100644 --- a/runtime/ops/fs.rs +++ b/runtime/ops/fs.rs @@ -524,13 +524,13 @@ fn op_umask(state: &mut OpState, mask: Option<u32>) -> Result<u32, AnyError> { } #[op] -fn op_chdir(state: &mut OpState, directory: String) -> Result<(), AnyError> { +fn op_chdir(state: &mut OpState, directory: &str) -> Result<(), AnyError> { let d = PathBuf::from(&directory); state .borrow_mut::<Permissions>() .read .check(&d, Some("Deno.chdir()"))?; - set_current_dir(&d).map_err(|err| { + set_current_dir(d).map_err(|err| { Error::new(err.kind(), format!("{}, chdir '{}'", err, directory)) })?; Ok(()) @@ -603,10 +603,10 @@ async fn op_mkdir_async( #[op] fn op_chmod_sync( state: &mut OpState, - path: String, + path: &str, mode: u32, ) -> Result<(), AnyError> { - let path = Path::new(&path); + let path = Path::new(path); let mode = mode & 0o777; state @@ -661,11 +661,11 @@ fn raw_chmod(path: &Path, _raw_mode: u32) -> Result<(), AnyError> { #[op] fn op_chown_sync( state: &mut OpState, - path: String, + path: &str, #[cfg_attr(windows, allow(unused_variables))] uid: Option<u32>, #[cfg_attr(windows, allow(unused_variables))] gid: Option<u32>, ) -> Result<(), AnyError> { - let path = Path::new(&path).to_path_buf(); + let path = Path::new(path).to_path_buf(); state .borrow_mut::<Permissions>() .write @@ -734,10 +734,10 @@ async fn op_chown_async( #[op] fn op_remove_sync( state: &mut OpState, - path: String, + path: &str, recursive: bool, ) -> Result<(), AnyError> { - let path = PathBuf::from(&path); + let path = PathBuf::from(path); state .borrow_mut::<Permissions>() @@ -835,11 +835,11 @@ async fn op_remove_async( #[op] fn op_copy_file_sync( state: &mut OpState, - from: String, - to: String, + from: &str, + to: &str, ) -> Result<(), AnyError> { - let from_path = PathBuf::from(&from); - let to_path = PathBuf::from(&to); + let from_path = PathBuf::from(from); + let to_path = PathBuf::from(to); let permissions = state.borrow_mut::<Permissions>(); permissions @@ -1097,11 +1097,11 @@ pub struct StatArgs { #[op] fn op_stat_sync( state: &mut OpState, - path: String, + path: &str, lstat: bool, out_buf: &mut [u32], ) -> Result<(), AnyError> { - let path = PathBuf::from(&path); + let path = PathBuf::from(path); state .borrow_mut::<Permissions>() .read @@ -1313,11 +1313,11 @@ async fn op_read_dir_async( #[op] fn op_rename_sync( state: &mut OpState, - oldpath: String, - newpath: String, + oldpath: &str, + newpath: &str, ) -> Result<(), AnyError> { - let oldpath = PathBuf::from(&oldpath); - let newpath = PathBuf::from(&newpath); + let oldpath = PathBuf::from(oldpath); + let newpath = PathBuf::from(newpath); let permissions = state.borrow_mut::<Permissions>(); permissions @@ -1382,11 +1382,11 @@ async fn op_rename_async( #[op] fn op_link_sync( state: &mut OpState, - oldpath: String, - newpath: String, + oldpath: &str, + newpath: &str, ) -> Result<(), AnyError> { - let oldpath = PathBuf::from(&oldpath); - let newpath = PathBuf::from(&newpath); + let oldpath = PathBuf::from(oldpath); + let newpath = PathBuf::from(newpath); let permissions = state.borrow_mut::<Permissions>(); permissions.read.check(&oldpath, Some("Deno.linkSync()"))?; @@ -1449,12 +1449,12 @@ async fn op_link_async( #[op] fn op_symlink_sync( state: &mut OpState, - oldpath: String, - newpath: String, + oldpath: &str, + newpath: &str, _type: Option<String>, ) -> Result<(), AnyError> { - let oldpath = PathBuf::from(&oldpath); - let newpath = PathBuf::from(&newpath); + let oldpath = PathBuf::from(oldpath); + let newpath = PathBuf::from(newpath); state .borrow_mut::<Permissions>() @@ -1669,10 +1669,10 @@ async fn op_ftruncate_async( #[op] fn op_truncate_sync( state: &mut OpState, - path: String, + path: &str, len: u64, ) -> Result<(), AnyError> { - let path = PathBuf::from(&path); + let path = PathBuf::from(path); state .borrow_mut::<Permissions>() @@ -1949,13 +1949,13 @@ async fn op_futime_async( #[op] fn op_utime_sync( state: &mut OpState, - path: String, + path: &str, atime_secs: i64, atime_nanos: u32, mtime_secs: i64, mtime_nanos: u32, ) -> Result<(), AnyError> { - let path = PathBuf::from(&path); + let path = PathBuf::from(path); let atime = filetime::FileTime::from_unix_time(atime_secs, atime_nanos); let mtime = filetime::FileTime::from_unix_time(mtime_secs, mtime_nanos); diff --git a/runtime/ops/io.rs b/runtime/ops/io.rs index 8ed6969f9..fd5b8a962 100644 --- a/runtime/ops/io.rs +++ b/runtime/ops/io.rs @@ -671,7 +671,7 @@ impl Resource for StdFileResource { #[op] pub fn op_print( state: &mut OpState, - msg: String, + msg: &str, is_err: bool, ) -> Result<(), AnyError> { let rid = if is_err { 2 } else { 1 }; diff --git a/runtime/ops/os/mod.rs b/runtime/ops/os/mod.rs index b93935955..844fbaecc 100644 --- a/runtime/ops/os/mod.rs +++ b/runtime/ops/os/mod.rs @@ -78,10 +78,10 @@ fn op_exec_path(state: &mut OpState) -> Result<String, AnyError> { #[op] fn op_set_env( state: &mut OpState, - key: String, - value: String, + key: &str, + value: &str, ) -> Result<(), AnyError> { - state.borrow_mut::<Permissions>().env.check(&key)?; + state.borrow_mut::<Permissions>().env.check(key)?; if key.is_empty() { return Err(type_error("Key is an empty string.")); } diff --git a/runtime/ops/signal.rs b/runtime/ops/signal.rs index 95c166787..66530a838 100644 --- a/runtime/ops/signal.rs +++ b/runtime/ops/signal.rs @@ -453,9 +453,9 @@ pub fn signal_int_to_str(s: libc::c_int) -> Result<&'static str, AnyError> { #[op] fn op_signal_bind( state: &mut OpState, - sig: String, + sig: &str, ) -> Result<ResourceId, AnyError> { - let signo = signal_str_to_int(&sig)?; + let signo = signal_str_to_int(sig)?; if signal_hook_registry::FORBIDDEN.contains(&signo) { return Err(type_error(format!( "Binding to signal '{}' is not allowed", @@ -474,9 +474,9 @@ fn op_signal_bind( #[op] fn op_signal_bind( state: &mut OpState, - sig: String, + sig: &str, ) -> Result<ResourceId, AnyError> { - let signo = signal_str_to_int(&sig)?; + let signo = signal_str_to_int(sig)?; let resource = SignalStreamResource { signal: AsyncRefCell::new(match signo { // SIGINT |