diff options
Diffstat (limited to 'ext/web/08_text_encoding.js')
-rw-r--r-- | ext/web/08_text_encoding.js | 75 |
1 files changed, 32 insertions, 43 deletions
diff --git a/ext/web/08_text_encoding.js b/ext/web/08_text_encoding.js index 2b7eb35bb..e563c8bd4 100644 --- a/ext/web/08_text_encoding.js +++ b/ext/web/08_text_encoding.js @@ -17,23 +17,26 @@ const { DataViewPrototypeGetBuffer, DataViewPrototypeGetByteLength, DataViewPrototypeGetByteOffset, + ObjectPrototypeIsPrototypeOf, PromiseReject, PromiseResolve, // TODO(lucacasonato): add SharedArrayBuffer to primordials - // SharedArrayBufferPrototype + // SharedArrayBufferPrototype, StringPrototypeCharCodeAt, StringPrototypeSlice, SymbolFor, - TypedArrayPrototypeSubarray, TypedArrayPrototypeGetBuffer, TypedArrayPrototypeGetByteLength, TypedArrayPrototypeGetByteOffset, - TypedArrayPrototypeGetSymbolToStringTag, - Uint8Array, - ObjectPrototypeIsPrototypeOf, - ArrayBufferIsView, + TypedArrayPrototypeSubarray, Uint32Array, + Uint8Array, } = primordials; +const { + isDataView, + isSharedArrayBuffer, + isTypedArray, +} = core; class TextDecoder { /** @type {string} */ @@ -111,51 +114,37 @@ class TextDecoder { try { /** @type {ArrayBufferLike} */ let buffer = input; - if (ArrayBufferIsView(input)) { - if (TypedArrayPrototypeGetSymbolToStringTag(input) !== undefined) { - // TypedArray - buffer = TypedArrayPrototypeGetBuffer( - /** @type {Uint8Array} */ (input), - ); - } else { - // DataView - buffer = DataViewPrototypeGetBuffer(/** @type {DataView} */ (input)); - } + if (isTypedArray(input)) { + buffer = TypedArrayPrototypeGetBuffer( + /** @type {Uint8Array} */ (input), + ); + } else if (isDataView(input)) { + buffer = DataViewPrototypeGetBuffer(/** @type {DataView} */ (input)); } // Note from spec: implementations are strongly encouraged to use an implementation strategy that avoids this copy. // When doing so they will have to make sure that changes to input do not affect future calls to decode(). - if ( - ObjectPrototypeIsPrototypeOf( - // deno-lint-ignore prefer-primordials - SharedArrayBuffer.prototype, - buffer, - ) - ) { + if (isSharedArrayBuffer(buffer)) { // We clone the data into a non-shared ArrayBuffer so we can pass it // to Rust. // `input` is now a Uint8Array, and calling the TypedArray constructor // with a TypedArray argument copies the data. - if (ArrayBufferIsView(input)) { - if (TypedArrayPrototypeGetSymbolToStringTag(input) !== undefined) { - // TypedArray - input = new Uint8Array( - buffer, - TypedArrayPrototypeGetByteOffset( - /** @type {Uint8Array} */ (input), - ), - TypedArrayPrototypeGetByteLength( - /** @type {Uint8Array} */ (input), - ), - ); - } else { - // DataView - input = new Uint8Array( - buffer, - DataViewPrototypeGetByteOffset(/** @type {DataView} */ (input)), - DataViewPrototypeGetByteLength(/** @type {DataView} */ (input)), - ); - } + if (isTypedArray(input)) { + input = new Uint8Array( + buffer, + TypedArrayPrototypeGetByteOffset( + /** @type {Uint8Array} */ (input), + ), + TypedArrayPrototypeGetByteLength( + /** @type {Uint8Array} */ (input), + ), + ); + } else if (isDataView(input)) { + input = new Uint8Array( + buffer, + DataViewPrototypeGetByteOffset(/** @type {DataView} */ (input)), + DataViewPrototypeGetByteLength(/** @type {DataView} */ (input)), + ); } else { input = new Uint8Array(buffer); } |