summaryrefslogtreecommitdiff
path: root/cli
diff options
context:
space:
mode:
Diffstat (limited to 'cli')
-rw-r--r--cli/js/buffer.ts6
-rw-r--r--cli/js/lib.deno.ns.d.ts14
-rw-r--r--cli/js/tests/buffer_test.ts1
3 files changed, 7 insertions, 14 deletions
diff --git a/cli/js/buffer.ts b/cli/js/buffer.ts
index fdacf70a9..dbe7606fd 100644
--- a/cli/js/buffer.ts
+++ b/cli/js/buffer.ts
@@ -6,7 +6,6 @@
import { Reader, Writer, ReaderSync, WriterSync } from "./io.ts";
import { assert } from "./util.ts";
-import { TextDecoder } from "./web/text_encoding.ts";
// MIN_READ is the minimum ArrayBuffer size passed to a read call by
// buffer.ReadFrom. As long as the Buffer has at least MIN_READ bytes beyond
@@ -44,11 +43,6 @@ export class Buffer implements Reader, ReaderSync, Writer, WriterSync {
return this.#buf.subarray(this.#off);
}
- toString(): string {
- const decoder = new TextDecoder();
- return decoder.decode(this.#buf.subarray(this.#off));
- }
-
empty(): boolean {
return this.#buf.byteLength <= this.#off;
}
diff --git a/cli/js/lib.deno.ns.d.ts b/cli/js/lib.deno.ns.d.ts
index d7d885b5b..aca0fc114 100644
--- a/cli/js/lib.deno.ns.d.ts
+++ b/cli/js/lib.deno.ns.d.ts
@@ -847,12 +847,6 @@ declare namespace Deno {
* least until the next buffer modification, so immediate changes to the
* slice will affect the result of future reads. */
bytes(): Uint8Array;
- /** Returns the contents of the unread portion of the buffer as a `string`.
- *
- * **Warning**: if multibyte characters are present when data is flowing
- * through the buffer, this method may result in incorrect strings due to a
- * character being split. */
- toString(): string;
/** Returns whether the unread portion of the buffer is empty. */
empty(): boolean;
/** A read only number of bytes of the unread portion of the buffer. */
@@ -873,9 +867,15 @@ declare namespace Deno {
readSync(p: Uint8Array): number | null;
/** Reads the next `p.length` bytes from the buffer or until the buffer is
* drained. Resolves to the number of bytes read. If the buffer has no
- * data to return, resolves to EOF (`null`). */
+ * data to return, resolves to EOF (`null`).
+ *
+ * NOTE: This methods reads bytes sychronously; it's provided for
+ * compatibility with `Reader` interfaces.
+ */
read(p: Uint8Array): Promise<number | null>;
writeSync(p: Uint8Array): number;
+ /** NOTE: This methods writes bytes sychronously; it's provided for
+ * compatibility with `Writer` interface. */
write(p: Uint8Array): Promise<number>;
/** Grows the buffer's capacity, if necessary, to guarantee space for
* another `n` bytes. After `.grow(n)`, at least `n` bytes can be written to
diff --git a/cli/js/tests/buffer_test.ts b/cli/js/tests/buffer_test.ts
index e45bcb976..ac2d7db7b 100644
--- a/cli/js/tests/buffer_test.ts
+++ b/cli/js/tests/buffer_test.ts
@@ -35,7 +35,6 @@ function check(buf: Deno.Buffer, s: string): void {
const decoder = new TextDecoder();
const bytesStr = decoder.decode(bytes);
assertEquals(bytesStr, s);
- assertEquals(buf.length, buf.toString().length);
assertEquals(buf.length, s.length);
}