diff options
| author | Divy Srivastava <dj.srivastava23@gmail.com> | 2023-08-19 09:56:12 +0530 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-08-19 09:56:12 +0530 |
| commit | c2259f78eb8180731bb562740695ab6e58c790e7 (patch) | |
| tree | b080b42ef86b3aa3802e7b3b7309d31cdf5f7ef8 /.github | |
| parent | 0e4469c7a1d9afcffc53d714e6db4491e552d5c9 (diff) | |
chore: remove third_party submodule (#20201)
removes third_party submodule, tools are installed on-demand.
- removed `load_test` and websocket benchmark (covered by benchy)
- removed node/bun http benchmarks (covered by benchy)
- `dlint` & `dprint` downloaded on-demand.
- `wrk` & `hyperfine` downloaded before CI benchmark run.
Install locally using: `./tools/install_prebuilt.js wrk hyperfine`
#### updating dlint/dprint
update version in `tools/util.js` and place binary in
`denoland/deno_third_party`.
Diffstat (limited to '.github')
| -rwxr-xr-x | .github/workflows/ci.generate.ts | 13 | ||||
| -rw-r--r-- | .github/workflows/ci.yml | 12 |
2 files changed, 13 insertions, 12 deletions
diff --git a/.github/workflows/ci.generate.ts b/.github/workflows/ci.generate.ts index cf9ec8ac1..77e34b102 100755 --- a/.github/workflows/ci.generate.ts +++ b/.github/workflows/ci.generate.ts @@ -65,8 +65,8 @@ sudo mount --rbind /sys /sysroot/sys sudo mount --rbind /home /sysroot/home sudo mount -t proc /proc /sysroot/proc -cp third_party/prebuilt/linux64/libdl/libdl.so.2 . -cp third_party/prebuilt/linux64/libdl/libdl.a . +wget https://github.com/denoland/deno_third_party/raw/master/prebuilt/linux64/libdl/libdl.a +wget https://github.com/denoland/deno_third_party/raw/master/prebuilt/linux64/libdl/libdl.so.2 sudo ln -s libdl.so.2 /sysroot/lib/x86_64-linux-gnu/libdl.so sudo ln -s libdl.a /sysroot/lib/x86_64-linux-gnu/libdl.a @@ -106,6 +106,8 @@ CFLAGS=-flto=thin --sysroot=/sysroot __0`, }; +const installBenchTools = "./tools/install_prebuilt.js wrk hyperfine"; + // The Windows builder is a little strange -- there's lots of room on C: and not so much on D: // We'll check out to D:, but then all of our builds should happen on a C:-mapped drive const reconfigureWindowsStorage = { @@ -395,7 +397,6 @@ const ci = { reconfigureWindowsStorage, ...cloneRepoStep, submoduleStep("./test_util/std"), - submoduleStep("./third_party"), { ...submoduleStep("./test_util/wpt"), if: "matrix.wpt", @@ -504,6 +505,8 @@ const ci = { 'if [ "${{ matrix.job }}" == "bench" ]', "then", " node -v", + // Install benchmark tools. + installBenchTools, "fi", ].join("\n"), }, @@ -552,7 +555,7 @@ const ci = { name: "test_format.js", if: "matrix.job == 'lint' && startsWith(matrix.os, 'ubuntu')", run: - "deno run --unstable --allow-write --allow-read --allow-run ./tools/format.js --check", + "deno run --unstable --allow-write --allow-read --allow-run --allow-net ./tools/format.js --check", }, { name: "Lint PR title", @@ -567,7 +570,7 @@ const ci = { name: "lint.js", if: "matrix.job == 'lint'", run: - "deno run --unstable --allow-write --allow-read --allow-run ./tools/lint.js", + "deno run --unstable --allow-write --allow-read --allow-run --allow-net ./tools/lint.js", }, { name: "node_compat/setup.ts --check", diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 945a5eed5..f97816325 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -128,9 +128,6 @@ jobs: - name: Clone submodule ./test_util/std run: git submodule update --init --recursive --depth=1 -- ./test_util/std if: '!(github.event_name == ''pull_request'' && matrix.skip_pr)' - - name: Clone submodule ./third_party - run: git submodule update --init --recursive --depth=1 -- ./third_party - if: '!(github.event_name == ''pull_request'' && matrix.skip_pr)' - name: Clone submodule ./test_util/wpt run: git submodule update --init --recursive --depth=1 -- ./test_util/wpt if: '!(github.event_name == ''pull_request'' && matrix.skip_pr) && (matrix.wpt)' @@ -252,8 +249,8 @@ jobs: sudo mount --rbind /home /sysroot/home sudo mount -t proc /proc /sysroot/proc - cp third_party/prebuilt/linux64/libdl/libdl.so.2 . - cp third_party/prebuilt/linux64/libdl/libdl.a . + wget https://github.com/denoland/deno_third_party/raw/master/prebuilt/linux64/libdl/libdl.a + wget https://github.com/denoland/deno_third_party/raw/master/prebuilt/linux64/libdl/libdl.so.2 sudo ln -s libdl.so.2 /sysroot/lib/x86_64-linux-gnu/libdl.so sudo ln -s libdl.a /sysroot/lib/x86_64-linux-gnu/libdl.a @@ -303,6 +300,7 @@ jobs: if [ "${{ matrix.job }}" == "bench" ] then node -v + ./tools/install_prebuilt.js wrk hyperfine fi if: '!(github.event_name == ''pull_request'' && matrix.skip_pr)' - name: Cache Cargo home @@ -332,7 +330,7 @@ jobs: cache-path: ./target - name: test_format.js if: '!(github.event_name == ''pull_request'' && matrix.skip_pr) && (matrix.job == ''lint'' && startsWith(matrix.os, ''ubuntu''))' - run: deno run --unstable --allow-write --allow-read --allow-run ./tools/format.js --check + run: deno run --unstable --allow-write --allow-read --allow-run --allow-net ./tools/format.js --check - name: Lint PR title if: '!(github.event_name == ''pull_request'' && matrix.skip_pr) && (matrix.job == ''lint'' && github.event_name == ''pull_request'' && startsWith(matrix.os, ''ubuntu''))' env: @@ -340,7 +338,7 @@ jobs: run: deno run ./tools/verify_pr_title.js "$PR_TITLE" - name: lint.js if: '!(github.event_name == ''pull_request'' && matrix.skip_pr) && (matrix.job == ''lint'')' - run: deno run --unstable --allow-write --allow-read --allow-run ./tools/lint.js + run: deno run --unstable --allow-write --allow-read --allow-run --allow-net ./tools/lint.js - name: node_compat/setup.ts --check if: '!(github.event_name == ''pull_request'' && matrix.skip_pr) && (matrix.job == ''lint'' && startsWith(matrix.os, ''ubuntu''))' run: deno run --allow-write --allow-read --allow-run=git ./tools/node_compat/setup.ts --check |
