From 22a03ad39a926b09ba6b8dc2a33988b80cae77a6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ville=20Skytt=C3=A4?= Date: Tue, 26 Jul 2016 19:57:23 +0300 Subject: Open/close files with "with" --- bs4/diagnose.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'bs4/diagnose.py') diff --git a/bs4/diagnose.py b/bs4/diagnose.py index cda2f01..8768332 100644 --- a/bs4/diagnose.py +++ b/bs4/diagnose.py @@ -58,7 +58,8 @@ def diagnose(data): data = data.read() elif os.path.exists(data): print '"%s" looks like a filename. Reading data from the file.' % data - data = open(data).read() + with open(data) as fp: + data = fp.read() elif data.startswith("http:") or data.startswith("https:"): print '"%s" looks like a URL. Beautiful Soup is not an HTTP client.' % data print "You need to use some other library to get the document behind the URL, and feed that document to Beautiful Soup." -- cgit v1.2.3