diff options
| author | Leonard Richardson <leonardr@segfault.org> | 2014-12-07 10:01:30 -0500 |
|---|---|---|
| committer | Leonard Richardson <leonardr@segfault.org> | 2014-12-07 10:01:30 -0500 |
| commit | 70e9f8c3d3250a2e780b00e2220a286638488000 (patch) | |
| tree | ecf9840aa94434669bb12c07a4c3a84ad8b71b18 /bs4 | |
| parent | bf58c02abf418556927363cf79cc86bee58d0592 (diff) | |
Tweaked the parser warning.
Diffstat (limited to 'bs4')
| -rw-r--r-- | bs4/__init__.py | 8 | ||||
| -rw-r--r-- | bs4/builder/__init__.py | 1 | ||||
| -rw-r--r-- | bs4/builder/_lxml.py | 5 |
3 files changed, 8 insertions, 6 deletions
diff --git a/bs4/__init__.py b/bs4/__init__.py index 34a72e4..b74acee 100644 --- a/bs4/__init__.py +++ b/bs4/__init__.py @@ -77,7 +77,7 @@ class BeautifulSoup(Tag): ASCII_SPACES = '\x20\x0a\x09\x0c\x0d' - NO_PARSER_SPECIFIED_WARNING = 'Parser was not explicitly specified. Using the best available parser for this system ("%s"). The same code on other systems may use a different parser and behave differently.' + NO_PARSER_SPECIFIED_WARNING = "No parser was explicitly specified, so I'm using the best available parser for this system (\"%(parser)s\"). This usually isn't a problem, but if you run this code on another system, or in a different virtual environment, it may use a different parser and behave differently.\n\nTo get rid of this warning, change this:\n\n BeautifulSoup([your markup])\n\nto this:\n\n BeautifulSoup([your markup], \"%(parser)s\")\n" def __init__(self, markup="", features=None, builder=None, parse_only=None, from_encoding=None, **kwargs): @@ -155,9 +155,9 @@ class BeautifulSoup(Tag): % ",".join(features)) builder = builder_class() if not (original_features == builder.NAME or - (not isinstance(builder.NAME, basestring) and - original_features in builder.NAME)): - warnings.warn(self.NO_PARSER_SPECIFIED_WARNING % builder.NAME) + original_features in builder.ALTERNATE_NAMES): + warnings.warn(self.NO_PARSER_SPECIFIED_WARNING % dict( + parser=builder.NAME)) self.builder = builder self.is_xml = builder.is_xml diff --git a/bs4/builder/__init__.py b/bs4/builder/__init__.py index 0e84fae..820bc80 100644 --- a/bs4/builder/__init__.py +++ b/bs4/builder/__init__.py @@ -81,6 +81,7 @@ class TreeBuilder(object): """Turn a document into a Beautiful Soup object tree.""" NAME = "[Unknown tree builder]" + ALTERNATE_NAMES = [] features = [] is_xml = False diff --git a/bs4/builder/_lxml.py b/bs4/builder/_lxml.py index 110e9d2..978c8df 100644 --- a/bs4/builder/_lxml.py +++ b/bs4/builder/_lxml.py @@ -214,9 +214,10 @@ class LXMLTreeBuilderForXML(TreeBuilder): class LXMLTreeBuilder(HTMLTreeBuilder, LXMLTreeBuilderForXML): - NAME = [LXML, "lxml-html"] + NAME = LXML + ALTERNATE_NAMES = ["lxml-html"] - features = NAME + [HTML, FAST, PERMISSIVE] + features = ALTERNATE_NAMES + [NAME, HTML, FAST, PERMISSIVE] is_xml = False def default_parser(self, encoding): |