Removed tests that merely illustrated parser behavior, behavior that wouldn't break Beautiful Soup if it changed.

1 files changed, 11 insertions, 313 deletions

diff --git a/bs4/tests/test_html5lib.py b/bs4/tests/test_html5lib.py
index 3f00d52..f1edddf 100644
--- a/bs4/tests/test_html5lib.py
+++ b/bs4/tests/test_html5lib.py
@@ -1,18 +1,22 @@
+"""Tests to ensure that the html5lib tree builder generates good trees."""
+
 try:
     from bs4.builder import HTML5TreeBuilder
     HTML5LIB_PRESENT = True
 except ImportError, e:
     HTML5LIB_PRESENT = False
-from bs4.element import Comment, SoupStrainer
-import test_htmlparser
-import unittest
-from bs4.testing import skipIf
+from bs4.element import SoupStrainer
+from bs4.testing import (
+    HTMLTreeBuilderSmokeTest,
+    SoupTest,
+    skipIf,
+)
 
 @skipIf(
     not HTML5LIB_PRESENT,
     "html5lib seems not to be present, not testing its tree builder.")
-class TestHTML5Builder(test_htmlparser.TestHTMLParserTreeBuilder):
-    """See `BuilderSmokeTest`."""
+class HTML5LibBuilderSmokeTest(SoupTest, HTMLTreeBuilderSmokeTest):
+    """See ``HTMLTreeBuilderSmokeTest``."""
 
     @property
     def default_builder(self):
@@ -27,15 +31,8 @@ class TestHTML5Builder(test_htmlparser.TestHTMLParserTreeBuilder):
         self.assertEqual(
             soup.decode(), self.document_for(markup))
 
-    def test_bare_string(self):
-        # A bare string is turned into some kind of HTML document or
-        # fragment recognizable as the original string.
-        #
-        # In this case, html5lib puts a <p> tag around the bare string.
-        self.assertSoupEquals(
-            "A bare string", "A bare string")
-
     def test_correctly_nested_tables(self):
+        """html5lib inserts <tbody> tags where other parsers don't."""
         markup = ('<table id="1">'
                   '<tr>'
                   "<td>Here's another table:"
@@ -53,302 +50,3 @@ class TestHTML5Builder(test_htmlparser.TestHTMLParserTreeBuilder):
             "<table><thead><tr><td>Foo</td></tr></thead>"
             "<tbody><tr><td>Bar</td></tr></tbody>"
             "<tfoot><tr><td>Baz</td></tr></tfoot></table>")
-
-    def test_literal_in_textarea(self):
-        markup = '<textarea>Junk like <b> tags and <&<&amp;</textarea>'
-        soup = self.soup(markup)
-        self.assertEqual(
-            soup.textarea.contents, ["Junk like <b> tags and <&<&"])
-
-    def test_collapsed_whitespace(self):
-        """Whitespace is preserved even in tags that don't require it."""
-        self.assertSoupEquals("<p>   </p>")
-        self.assertSoupEquals("<b>   </b>")
-
-    def test_cdata_where_its_ok(self):
-        # In html5lib 0.9.0, all CDATA sections are converted into
-        # comments.  In a later version (unreleased as of this
-        # writing), CDATA sections in tags like <svg> and <math> will
-        # be preserved. BUT, I'm not sure how Beautiful Soup needs to
-        # adjust to transform this preservation into the construction
-        # of a BS CData object.
-        markup = "<svg><![CDATA[foobar]]>"
-
-        # Eventually we should be able to do a find(text="foobar") and
-        # get a CData object.
-        self.assertSoupEquals(markup, "<svg><!--[CDATA[foobar]]--></svg>")
-
-    def test_entities_in_attribute_values_converted_during_parsing(self):
-
-        # The numeric entity is recognized even without the closing
-        # semicolon.
-        text = '<x t="pi&#241ata">'
-        expected = u"pi\N{LATIN SMALL LETTER N WITH TILDE}ata"
-        soup = self.soup(text)
-        self.assertEqual(soup.x['t'], expected)
-
-    def test_naked_ampersands(self):
-        # Ampersands are not treated as entities, unlike in html.parser.
-        text = "<p>AT&T</p>"
-        soup = self.soup(text)
-        self.assertEqual(soup.p.string, "AT&T")
-
-    def test_namespaced_system_doctype(self):
-        # Test a namespaced doctype with a system id.
-        self._test_doctype('xsl:stylesheet SYSTEM "htmlent.dtd"')
-
-    def test_namespaced_public_doctype(self):
-        # Test a namespaced doctype with a public id.
-        self._test_doctype('xsl:stylesheet PUBLIC "htmlent.dtd"')
-
-
-@skipIf(
-    not HTML5LIB_PRESENT,
-    "html5lib seems not to be present, not testing it on invalid markup.")
-class TestHTML5BuilderInvalidMarkup(
-    test_htmlparser.TestHTMLParserTreeBuilderInvalidMarkup):
-    """See `BuilderInvalidMarkupSmokeTest`."""
-
-    @property
-    def default_builder(self):
-        return HTML5TreeBuilder()
-
-    def test_unclosed_block_level_elements(self):
-        # The unclosed <b> tag is closed so that the block-level tag
-        # can be closed, and another <b> tag is inserted after the
-        # next block-level tag begins.
-        self.assertSoupEquals(
-            '<blockquote><p><b>Foo</blockquote><p>Bar',
-            '<blockquote><p><b>Foo</b></p></blockquote><p><b>Bar</b></p>')
-
-    def test_attribute_value_never_got_closed(self):
-        markup = '<a href="http://foo.com/</a> and blah and blah'
-        soup = self.soup(markup)
-        self.assertEqual(
-            soup.a['href'], "http://foo.com/</a> and blah and blah")
-
-    def test_attribute_value_was_closed_by_subsequent_tag(self):
-        markup = """<a href="foo</a>, </a><a href="bar">baz</a>"""
-        soup = self.soup(markup)
-        # The string between the first and second quotes was interpreted
-        # as the value of the 'href' attribute.
-        self.assertEqual(soup.a['href'], 'foo</a>, </a><a href=')
-
-        #The string after the second quote (bar"), was treated as an
-        #empty attribute called bar.
-        self.assertEqual(soup.a['bar'], '')
-        self.assertEqual(soup.a.string, "baz")
-
-    def test_document_starts_with_bogus_declaration(self):
-        soup = self.soup('<! Foo ><p>a</p>')
-        # The declaration is ignored altogether.
-        self.assertEqual(soup.encode(), b"<html><body><p>a</p></body></html>")
-
-    def test_table_containing_bare_markup(self):
-        # Markup should be in table cells, not directly in the table.
-        self.assertSoupEquals("<table><div>Foo</div></table>",
-                              "<div>Foo</div><table></table>")
-
-    def test_unclosed_a_tag(self):
-        # n.b. the whitespace is important here.
-        markup = """<div id="1">
- <a href="foo">
-</div>
-<div id="2">
- <div id="3">
-   <a href="bar"></a>
-  </div>
-</div>"""
-
-        expect = """<div id="1">
- <a href="foo">
-</a></div><a href="foo">
-</a><div id="2"><a href="foo">
- </a><div id="3"><a href="foo">
-   </a><a href="bar"></a>
-  </div>
-</div>"""
-        self.assertSoupEquals(markup, expect)
-
-    def test_incorrectly_nested_tables(self):
-        self.assertSoupEquals(
-            '<table><tr><table><tr id="nested">',
-            ('<table><tbody><tr></tr></tbody></table>'
-             '<table><tbody><tr id="nested"></tr></tbody></table>'))
-
-    def test_floating_text_in_table(self):
-        self.assertSoupEquals(
-            "<table><td></td>foo<td>bar</td></table>",
-            "foo<table><tbody><tr><td></td><td>bar</td></tr></tbody></table>")
-
-    def test_empty_element_tag_with_contents(self):
-        self.assertSoupEquals("<br>foo</br>", "<br/>foo<br/>")
-
-    def test_doctype_in_body(self):
-        markup = "<p>one<!DOCTYPE foobar>two</p>"
-        self.assertSoupEquals(markup, "<p>onetwo</p>")
-
-    def test_cdata_where_it_doesnt_belong(self):
-        # Random CDATA sections are converted into comments.
-        markup = "<div><![CDATA[foo]]>"
-        soup = self.soup(markup)
-        data = soup.find(text="[CDATA[foo]]")
-        self.assertEqual(data.__class__, Comment)
-
-    def test_nonsensical_declaration(self):
-        # Declarations that don't make any sense are turned into comments.
-        soup = self.soup('<! Foo = -8><p>a</p>')
-        self.assertEqual(str(soup),
-                          ("<!-- Foo = -8-->"
-                           "<html><head></head><body><p>a</p></body></html>"))
-
-        soup = self.soup('<p>a</p><! Foo = -8>')
-        self.assertEqual(str(soup),
-                          ("<html><head></head><body><p>a</p>"
-                           "<!-- Foo = -8--></body></html>"))
-
-    def test_whitespace_in_doctype(self):
-        # A declaration that has extra whitespace is turned into a comment.
-        soup = self.soup((
-                '<! DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN">'
-                '<p>foo</p>'))
-        self.assertEqual(
-            str(soup),
-            ('<!-- DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"-->'
-             '<html><head></head><body><p>foo</p></body></html>'))
-
-    def test_incomplete_declaration(self):
-        # An incomplete declaration is treated as a comment.
-        markup = 'a<!b <p>c'
-        self.assertSoupEquals(markup, "a<!--b &lt;p-->c")
-
-        # Let's spell that out a little more explicitly.
-        soup = self.soup(markup)
-        str1, comment, str2 = soup.body.contents
-        self.assertEqual(str1, 'a')
-        self.assertEqual(comment.__class__, Comment)
-        self.assertEqual(comment, 'b <p')
-        self.assertEqual(str2, 'c')
-
-    def test_document_starts_with_bogus_declaration(self):
-        soup = self.soup('<! Foo >a')
-        # 'Foo' becomes a comment that appears before the HTML.
-        comment = soup.contents[0]
-        self.assertTrue(isinstance(comment, Comment))
-        self.assertEqual(comment, 'Foo')
-
-        self.assertEqual(self.find(text="a") == "a")
-
-    def test_attribute_value_was_closed_by_subsequent_tag(self):
-        markup = """<a href="foo</a>, </a><a href="bar">baz</a>"""
-        soup = self.soup(markup)
-        # The string between the first and second quotes was interpreted
-        # as the value of the 'href' attribute.
-        self.assertEqual(soup.a['href'], 'foo</a>, </a><a href=')
-
-        #The string after the second quote (bar"), was treated as an
-        #empty attribute called bar".
-        self.assertEqual(soup.a['bar"'], '')
-        self.assertEqual(soup.a.string, "baz")
-
-    def test_document_starts_with_bogus_declaration(self):
-        soup = self.soup('<! Foo ><p>a</p>')
-        # The declaration becomes a comment.
-        comment = soup.contents[0]
-        self.assertTrue(isinstance(comment, Comment))
-        self.assertEqual(comment, ' Foo ')
-        self.assertEqual(soup.p.string, 'a')
-
-    def test_document_ends_with_incomplete_declaration(self):
-        soup = self.soup('<p>a<!b')
-        # This becomes a string 'a'. The incomplete declaration is ignored.
-        # Compare html5lib, which turns it into a comment.
-        s, comment = soup.p.contents
-        self.assertEqual(s, 'a')
-        self.assertTrue(isinstance(comment, Comment))
-        self.assertEqual(comment, 'b')
-
-    def test_entity_was_not_finished(self):
-        soup = self.soup("<p>&lt;Hello&gt")
-        # Compare html5lib, which completes the entity.
-        self.assertEqual(soup.p.string, "<Hello>")
-
-    def test_nonexistent_entity(self):
-        soup = self.soup("<p>foo&#bar;baz</p>")
-        self.assertEqual(soup.p.string, "foo&#bar;baz")
-
-        # Compare a real entity.
-        soup = self.soup("<p>foo&#100;baz</p>")
-        self.assertEqual(soup.p.string, "foodbaz")
-
-    def test_entity_out_of_range(self):
-        # An entity that's out of range will be converted to
-        # REPLACEMENT CHARACTER.
-        soup = self.soup("<p>&#10000000000000;</p>")
-        self.assertEqual(soup.p.string, u"\N{REPLACEMENT CHARACTER}")
-
-        soup = self.soup("<p>&#x1000000000000;</p>")
-        self.assertEqual(soup.p.string, u"\N{REPLACEMENT CHARACTER}")
-
-    def test_incomplete_declaration(self):
-        self.assertSoupEquals('a<!b <p>c', 'a<!--b &lt;p-->c')
-
-    def test_nonsensical_declaration(self):
-        soup = self.soup('<! Foo = -8><p>a</p>')
-        self.assertEquals(
-            soup.decode(),
-            "<!-- Foo = -8--><html><head></head><body><p>a</p></body></html>")
-
-    def test_unquoted_attribute_value(self):
-        soup = self.soup('<a style={height:21px;}></a>')
-        self.assertEqual(soup.a['style'], '{height:21px;}')
-
-    def test_boolean_attribute_with_no_value(self):
-        soup = self.soup("<table><td nowrap>foo</td></table>")
-        self.assertEqual(soup.table.td['nowrap'], '')
-
-    def test_cdata_where_it_doesnt_belong(self):
-        #CDATA sections are ignored.
-        markup = "<div><![CDATA[foo]]>"
-        self.assertSoupEquals(markup, "<div><!--[CDATA[foo]]--></div>")
-
-    def test_empty_element_tag_with_contents(self):
-        self.assertSoupEquals("<br>foo</br>", "<br/>foo<br/>")
-
-    def test_fake_self_closing_tag(self):
-        # If a self-closing tag presents as a normal tag, the 'open'
-        # tag is treated as an instance of the self-closing tag and
-        # the 'close' tag is ignored.
-        self.assertSoupEquals(
-            "<item><link>http://foo.com/</link></item>",
-            "<item><link/>http://foo.com/</item>")
-
-    def test_paragraphs_containing_block_display_elements(self):
-        markup = self.soup("<p>this is the definition:"
-                           "<dl><dt>first case</dt>")
-        # The <p> tag is closed before the <dl> tag begins.
-        self.assertEqual(markup.p.contents, ["this is the definition:"])
-
-    def test_multiple_values_for_the_same_attribute(self):
-        markup = '<b b="20" a="1" b="10" a="2" a="3" a="4"></b>'
-        self.assertSoupEquals(markup, '<b a="1" b="20"></b>')
-
-
-@skipIf(
-    not HTML5LIB_PRESENT,
-    "html5lib seems not to be present, not testing it on encoding conversion.")
-class TestHTML5LibEncodingConversion(
-    test_htmlparser.TestHTMLParserTreeBuilderEncodingConversion):
-    @property
-    def default_builder(self):
-        return HTML5TreeBuilder()
-
-    def test_real_hebrew_document(self):
-        # A real-world test to make sure we can convert ISO-8859-8 (a
-        # Hebrew encoding) to UTF-8.
-        soup = self.soup(self.HEBREW_DOCUMENT,
-                         from_encoding="iso-8859-8")
-        self.assertEqual(soup.original_encoding, 'iso8859-8')
-        self.assertEqual(
-            soup.encode('utf-8'),
-            self.HEBREW_DOCUMENT.decode("iso-8859-8").encode("utf-8"))